Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE Image position options #6

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Aug 14, 2024

No description provided.

@jsirish jsirish requested a review from muskie9 August 14, 2024 03:08
@jsirish
Copy link
Member Author

jsirish commented Aug 14, 2024

The template works as expected when full width, but it's not stacking when set to col-md-6 or lower like we discussed. I'd like to commit the positioning updates and work on the stacking in a different PR.

@jsirish
Copy link
Member Author

jsirish commented Aug 14, 2024

However it occurs to me that you can position the image as needed for desktop in the elemental grid. If I'm going to set the block to col-md-6, I can simply move the image to the top. If col-md-7 or larger I would pick left or right.

@jsirish
Copy link
Member Author

jsirish commented Aug 14, 2024

Screenshot 2024-08-14 at 8 23 16 AM

@jsirish jsirish merged commit e6018e7 into dynamic:master Aug 14, 2024
8 of 9 checks passed
@jsirish jsirish deleted the feature/imagePosition branch August 14, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants